Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move --break-system-packages settings to env variables #4378

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

mewim
Copy link
Member

@mewim mewim commented Oct 16, 2024

Description

We used --break-system-packages flags to work around PEP 668. However, this is not very robust. If the Python version is lower than expected, it will fail due to having an extra flag set. In this PR, we remove the flag and use env variables to pass it instead. The higher versions of Python should recognize the env and automaitcally set it for each pip install, while for lower versions this will be safely ignored.

Copy link

Benchmark Result

Master commit hash: 2af5c7e069e7b060f21ebefb1bdf1c2b76f4364e
Branch commit hash: e39a1bf4e67484e2a131482581b5b4cb03979d93

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 659.37 659.13 0.24 (0.04%)
aggregation q28 12036.55 11493.50 543.05 (4.72%)
filter q14 140.70 141.87 -1.17 (-0.82%)
filter q15 145.15 140.90 4.25 (3.02%)
filter q16 322.07 322.68 -0.61 (-0.19%)
filter q17 466.23 461.47 4.75 (1.03%)
filter q18 1948.58 1945.58 3.00 (0.15%)
fixed_size_expr_evaluator q07 560.97 562.71 -1.75 (-0.31%)
fixed_size_expr_evaluator q08 775.44 777.65 -2.22 (-0.28%)
fixed_size_expr_evaluator q09 778.27 775.53 2.75 (0.35%)
fixed_size_expr_evaluator q10 256.21 255.48 0.73 (0.29%)
fixed_size_expr_evaluator q11 251.18 250.30 0.89 (0.35%)
fixed_size_expr_evaluator q12 249.42 248.49 0.93 (0.37%)
fixed_size_expr_evaluator q13 1483.77 1484.68 -0.91 (-0.06%)
fixed_size_seq_scan q23 137.52 131.31 6.21 (4.73%)
join q29 654.15 628.83 25.32 (4.03%)
join q30 1437.68 1466.25 -28.57 (-1.95%)
join q31 12.13 10.02 2.11 (21.09%)
ldbc_snb_ic q35 417.58 376.74 40.85 (10.84%)
ldbc_snb_ic q36 39.33 41.36 -2.03 (-4.91%)
ldbc_snb_is q32 9.83 4.58 5.25 (114.50%)
ldbc_snb_is q33 13.59 13.34 0.24 (1.80%)
ldbc_snb_is q34 3.58 4.23 -0.64 (-15.19%)
multi-rel multi-rel-large-scan 1655.75 1699.83 -44.09 (-2.59%)
multi-rel multi-rel-lookup 44.12 54.04 -9.92 (-18.36%)
multi-rel multi-rel-small-scan 67.13 73.92 -6.79 (-9.19%)
order_by q25 149.21 146.38 2.83 (1.94%)
order_by q26 476.88 483.09 -6.21 (-1.29%)
order_by q27 1512.55 1508.95 3.60 (0.24%)
scan_after_filter q01 185.87 187.17 -1.30 (-0.69%)
scan_after_filter q02 173.28 173.64 -0.37 (-0.21%)
shortest_path_ldbc100 q37 3382.33 3424.20 -41.87 (-1.22%)
shortest_path_ldbc100 q38 67.66 64.75 2.91 (4.49%)
shortest_path_ldbc100 q39 47.48 54.48 -7.00 (-12.85%)
shortest_path_ldbc100 q40 72.59 68.57 4.01 (5.85%)
var_size_expr_evaluator q03 2078.23 2090.92 -12.69 (-0.61%)
var_size_expr_evaluator q04 2286.80 2291.04 -4.24 (-0.19%)
var_size_expr_evaluator q05 2678.95 2672.32 6.62 (0.25%)
var_size_expr_evaluator q06 1333.27 1336.08 -2.81 (-0.21%)
var_size_seq_scan q19 1480.82 1513.40 -32.58 (-2.15%)
var_size_seq_scan q20 2661.47 2676.26 -14.79 (-0.55%)
var_size_seq_scan q21 2279.11 2293.86 -14.75 (-0.64%)
var_size_seq_scan q22 131.80 132.46 -0.67 (-0.50%)

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (2af5c7e) to head (b5a1513).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4378   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files        1355     1355           
  Lines       53639    53640    +1     
  Branches     7108     7108           
=======================================
+ Hits        47318    47319    +1     
  Misses       6147     6147           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim merged commit fcee678 into master Oct 16, 2024
26 checks passed
@mewim mewim deleted the break-system-packages branch October 16, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants