Include additonal devices #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using this fact for years, but with the changes in RHEL etc to use /dev/mapper/vg-host-lv naming for devices, we need these to be picked up. Removing this line appears to allow this to happen correctly.
|
Hi @schiznik! Thank you for taking the time to fix my code! Much appreciated! Merry Christmas (or Happy Holidays) to you! 🎄 Given the nature of the change - which is to remove the symbolic link resolution - it might break things for others who use this fact. What do you think? I gather, that you would prefer for this not to resolve the underlying symbolic link, correct? Also, if this is not too much work, can you show me your Thank you in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using this fact for years, but with the changes in RHEL etc to use /dev/mapper/vg-host-lv naming for devices, we need these to be picked up.
Removing this line appears to allow this to happen correctly.