Feature/usps issue77 #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging changes from upstream
…form across packages) In situations where mail services aren't available on package 1 but are on package 2...we'll now exclude these if the requireUniformMailServices parameter is set to true on the USPS Domestic and International providers.
|
Hey @kylewest wanted to see if you can take a look into merging this. I've been using it in production for the last ~2 months without issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly called this feature issue77. This is actually in reference to #74.
This now allows a parameter called requireUniformMailServices (lovely name, right?) to be passed to the USPS providers (both domestic and international). If true, any mail services that aren't present in each returned package are excluded. If anything is excluded, a new field on the Shipment class called InfoMessages (which will have a list of InfoMessages) will populate with a message of all the excluded rates. In the future, the InfoMessages field can be leveraged for information like this...so you'll see a ShippingProvider and Message associated to each InfoMessage. :)
Finally, a "RatesExcluded" field will populate true on Shipment. This was used for unit testing on the USPS Domestic class, but more-so so that if rates are excluded...the consumer of the SDK can give a different message if they'd like to the user.