Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cloudflare workers test. #574

Merged
merged 13 commits into from
Jul 13, 2023
Merged

add cloudflare workers test. #574

merged 13 commits into from
Jul 13, 2023

Conversation

igalklebanov
Copy link
Member

@igalklebanov igalklebanov commented Jul 9, 2023 •
edited
Loading

Hey 👋

This PR proves Kysely can run in Cloudflare Workers, and PostgresDialect can execute queries.

Though Cloudflare Workers behave similarly to JavaScript in the browser or in Node.js, there are a few differences in how you have to think about your code. Under the hood, the Workers runtime uses the V8 engine — the same engine used by Chromium and Node.js. The Workers runtime also implements many of the standard APIs available in most modern browsers.
https://developers.cloudflare.com/workers/learning/how-workers-works/

@vercel
Copy link

vercel bot commented Jul 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 8:16am

@igalklebanov igalklebanov marked this pull request as ready for review July 9, 2023 21:48
koskimas
koskimas approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igalklebanov igalklebanov merged commit 3de0093 into kysely-org:master Jul 13, 2023
4 checks passed
@igalklebanov igalklebanov deleted the cloudflare-workers-test branch July 13, 2023 08:43
Gaspero pushed a commit to Gaspero/kysely that referenced this pull request Oct 2, 2023
@igalklebanov @Gaspero
add cloudflare workers test. (kysely-org#574)
39e6ed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas koskimas approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igalklebanov @koskimas