Convert SelectQueryBuilder and RawBuilder to interfaces
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
koskimas
force-pushed
the
get-rid-of-most-troublesome-classes
branch
from
0181785
to
2fa4c4c
Compare
koskimas
changed the title
SelectQueryBuilder and RawBuilder into interfacesSelectQueryBuilder and RawBuilder to interfaces
koskimas
force-pushed
the
get-rid-of-most-troublesome-classes
branch
from
2fa4c4c
to
6a13e39
Compare
igalklebanov
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
This hopefully will cause less headaches for us, our users, and https://github.com/serverless-stack/sst's users/maintainers. 🙏
LGTM! 🚀
We should probably add a test that uses a query builder from another Kysely instance as an argument, but with the same Database interface, and verify it still works and doesn't throw compilation/runtime errors.
igalklebanov
added
bug
koskimas
force-pushed
the
get-rid-of-most-troublesome-classes
branch
from
6a13e39
to
a2af9d6
Compare
Gaspero
pushed a commit
to Gaspero/kysely
that referenced
this pull request
Oct 2, 2023
…rg#589) * Convert RawBuilder to interface * Convert SelectQueryBuilder to interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My guess is that these two classes are most used ones (in addition to Kysely) in customer code. By turning them to interfaces we get rid of some of the type mismatches when there are multiple versions of Kysely.