Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] To add Karpenter Do Not Disrupt policy for Karpenter 1.x version #1191

Open
2 tasks done
jkannan-talend opened this issue Oct 24, 2024 · 3 comments · May be fixed by #1209
Open
2 tasks done

[Feature] To add Karpenter Do Not Disrupt policy for Karpenter 1.x version #1191

jkannan-talend opened this issue Oct 24, 2024 · 3 comments · May be fixed by #1209
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jkannan-talend
Copy link

Problem Statement

Currently, we are using this Kyverno policy to add the "karpenter.sh/do-not-evict" tag to Kubernetes resources. This tag is not supported in Karpenter version 1.x and has been replaced by the "karpenter.sh/do-not-disrupt" tag. To ensure a smooth upgrade from Karpenter 0.37 to version 1.x, we will need to apply the additional Kyverno policy for add-karpenter-donot-disrupt.

Reference for this change from Karpenter - https://karpenter.sh/v1.0/upgrading/v1-migration/

Solution Description

Adding the policy document for add-karpenter-donot-disrupt to support the Karpenter 1.x version upgrade.

Alternatives

No response

Additional Context

No response

Slack discussion

No response

Research

  • I have read and followed the documentation AND the troubleshooting guide.
  • I have searched other issues in this repository and mine is not recorded.
@jkannan-talend jkannan-talend added the enhancement New feature or request label Oct 24, 2024
@welcome Welcome
Copy link

welcome bot commented Oct 24, 2024

Thanks for opening your first issue here! Be sure to follow the issue template!

@realshuting
Copy link
Member

Looks like a new sample policy to add, transferring the issue.

@realshuting realshuting transferred this issue from kyverno/kyverno Oct 25, 2024
@realshuting realshuting added the good first issue Good for newcomers label Oct 25, 2024
Indrranil added a commit to Indrranil/policies that referenced this issue Dec 17, 2024
@Indrranil
[Feature] Add Karpenter Do Not Disrupt policy for Karpenter 1.x migra…
8a579db 
…tion

This policy adds the karpenter.sh/do-not-disrupt label to pods that have
the deprecated karpenter.sh/do-not-evict label to ensure smooth upgrades
from Karpenter 0.x to 1.x versions.

Fixes kyverno#1191

Signed-off-by: Indrranil Pawar <[email protected]>
@Indrranil
Copy link

@realshuting Hi I accidentally committed this directly to the main repo instead of my fork. Could you please help remove this commit? I will submit it properly through a PR from my fork afterwards. Really sorry for the confusion!

@Indrranil Indrranil linked a pull request Dec 17, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Good First Issues
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] Add Karpenter Do Not Disrupt policy for Karpenter 1.x migration Indrranil/policies
3 participants
@realshuting @jkannan-talend @Indrranil