Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Karpenter Do Not Disrupt policy for Karpenter 1.x migration #1209

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Indrranil
Copy link

[Feature] Add Karpenter Do Not Disrupt policy for Karpenter 1.x migration

This policy adds the karpenter.sh/do-not-disrupt label to pods that have the deprecated karpenter.sh/do-not-evict label to ensure smooth upgrades from Karpenter 0.x to 1.x versions.

Fixes #1191

Related Issue(s)

  • Issue #1191: To add Karpenter Do Not Disrupt policy for Karpenter 1.x version

Description

This PR:

  • Adds a new policy to facilitate migration from Karpenter 0.x to 1.x
  • Automatically adds karpenter.sh/do-not-disrupt label to pods having the deprecated karpenter.sh/do-not-evict label

Checklist

  • I have read the policy contribution guidelines
  • I have added the artifacthub-pkg.yml file and have verified it is complete and correct.
  • I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.

…tion

This policy adds the karpenter.sh/do-not-disrupt label to pods that have
the deprecated karpenter.sh/do-not-evict label to ensure smooth upgrades
from Karpenter 0.x to 1.x versions.

Fixes kyverno#1191

Signed-off-by: Indrranil Pawar <[email protected]>
Added chainsaw and kyverno test files to verify policy behavior for:
- Label mutation from do-not-evict to do-not-disrupt
- Proper handling of pods with and without the original label
- Policy readiness verification

Signed-off-by: Indrranil Pawar <[email protected]>
@realshuting
Copy link
Member

Hi @jkannan-talend - can you please help with the review?

@realshuting
Copy link
Member

Hi @jkannan-talend - can you please help with the review?

Kindly ping @jkannan-talend ⬆️

@Indrranil
Copy link
Author

Hi @jkannan-talend could you take a look at this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] To add Karpenter Do Not Disrupt policy for Karpenter 1.x version
2 participants