Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add best practices check-deprecated-apis policy in CEL expressions #1042

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

Chandan-DK
Copy link
Contributor

Related Issue(s)

Partially addresses #891

Description

PR to convert check-deprecated-apis policy in the best-practices folder to CEL

Checklist

  • [] I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

Signed-off-by: Chandan-DK <[email protected]>
Signed-off-by: Chandan-DK <[email protected]>
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chandan-DK
Copy link
Contributor Author

@MariamFahmy98 We probably have to wait for this issue (kyverno/kyverno#10313) to be resolved before merging this PR. This policy won't function properly as of now (Comment link for the details: #1042 (comment))

@chipzoller chipzoller enabled auto-merge (squash) August 2, 2024 12:25
@chipzoller chipzoller merged commit 2d8b3a4 into kyverno:main Aug 2, 2024
40 checks passed
@Chandan-DK Chandan-DK deleted the check-deprecated-apis-cel branch August 2, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants