Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chainsaw Tests] Add Chainsaw test for Bare Pods #1057

Merged
merged 9 commits into from
Jul 14, 2024

Conversation

Jay179-sudo
Copy link
Contributor

Related Issue(s)

Partial fix for #950

Description

Added chainsaw test for bare pods. Also added a test pod and a cluster-role manifest file.

Checklist

  • I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

…ponding clusterrole definition for the test

Signed-off-by: Jay179-sudo <[email protected]>
@Jay179-sudo
Copy link
Contributor Author

Maybe we can also reduce the scheduled time on the ClusterCleanupPolicy file from five minutes down to one minute to reduce CI time?
Please do let me know if any other issues persist.

@realshuting
Copy link
Member

Maybe we can also reduce the scheduled time on the ClusterCleanupPolicy file from five minutes down to one minute to reduce CI time? Please do let me know if any other issues persist.

Makes sense, can you replicate the same policy and reduce the scheduled time to a minute?

… changes to the original policy

Signed-off-by: Jay179-sudo <[email protected]>
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the ClusterRole inside the .chainsaw-test directory.

@Jay179-sudo
Copy link
Contributor Author

@chipzoller any updates on this?

Copy link

@mohamedawnallah mohamedawnallah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Jay179-sudo! 💪 Left some nit comments...

Signed-off-by: Jay179-sudo <[email protected]>
@Jay179-sudo Jay179-sudo requested a review from chipzoller July 13, 2024 14:18
@chipzoller chipzoller merged commit ff0b4d2 into kyverno:main Jul 14, 2024
225 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants