Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add other policies in CEL expressions - Part 4 #964

Merged
merged 32 commits into from
May 30, 2024

Conversation

Chandan-DK
Copy link
Contributor

@Chandan-DK Chandan-DK commented Apr 9, 2024

Related Issue(s)

Partially addresses #891

Description

This PR includes the conversion of policies in the other folder to Kyverno CEL policies. Conversion of the policies is done in multiple PRs

Policies converted in this PR:

  • require-annotations
  • require-deployments-have-multiple-replicas
  • require-image-checksum
  • require-ingress-https
  • require-pod-priorityclassname
  • require-qos-burstable
  • require-storageclass

Checklist

  • [] I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

Signed-off-by: Chandan-DK <[email protected]>
Signed-off-by: Chandan-DK <[email protected]>
Signed-off-by: Chandan-DK <[email protected]>
Signed-off-by: Chandan-DK <[email protected]>
Signed-off-by: Chandan-DK <[email protected]>
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK Chandan-DK force-pushed the other-policies-cel-part-4 branch from a97b039 to 4faf096 Compare April 12, 2024 17:08
@Chandan-DK Chandan-DK marked this pull request as ready for review April 12, 2024 17:10
@MariamFahmy98 MariamFahmy98 self-requested a review April 22, 2024 12:55
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test require-qos-burstable fails because of the following error:

l.go:53: ���������| 18:07:17 | require-qos-burstable | step-01  | PATCH     | ERROR | kyverno.io/v1/ClusterPolicy @ require-qos-burstable
        === ERROR
        Operation cannot be fulfilled on clusterpolicies.kyverno.io "require-qos-burstable": the object has been modified; please apply your changes to the latest version and try again
    l.go:53: ���������| 18:07:19 | require-qos-burstable | step-01  | PATCH     | ERROR | kyverno.io/v1/ClusterPolicy @ require-qos-burstable
        === ERROR
        Patch "https://127.0.0.1:33439/apis/kyverno.io/v1/clusterpolicies/require-qos-burstable": context deadline exceeded
    l.go:53: ���������| 18:07:19 | require-qos-burstable | step-01  | PATCH     | ERROR | kyverno.io/v1/ClusterPolicy @ require-qos-burstable
        === ERROR
        Patch "https://127.0.0.1:33439/apis/kyverno.io/v1/clusterpolicies/require-qos-burstable": context deadline exceeded

@MariamFahmy98 MariamFahmy98 self-assigned this Apr 23, 2024
@MariamFahmy98
Copy link
Contributor

@Chandan-DK - Could you please resolve the conflicts?

@Chandan-DK Chandan-DK force-pushed the other-policies-cel-part-4 branch from fcd4675 to ed87d82 Compare May 15, 2024 18:33
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MariamFahmy98 MariamFahmy98 merged commit c2fc68a into kyverno:main May 30, 2024
169 checks passed
@Chandan-DK Chandan-DK deleted the other-policies-cel-part-4 branch June 7, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants