Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor update installation methods #1339

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

dixudx
Copy link
Contributor

@dixudx dixudx commented Sep 9, 2024

Related issue

Proposed Changes

Minor update the installation part for better guidance, especially for beginners.

Checklist

  • I have read the contributing guidelines.
  • I have inspected the website preview for accuracy.
  • [] I have signed off my issue.

Copy link

welcome bot commented Sep 9, 2024

Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off.

@dixudx
Copy link
Contributor Author

dixudx commented Sep 9, 2024

cc @realshuting @JimBugwadia

Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dixudx
Copy link
Contributor Author

dixudx commented Sep 9, 2024

/retest

@JimBugwadia
Copy link
Member

JimBugwadia commented Sep 9, 2024

The changes look good, but there seem to be some errors due to broken links.

Should we create a separate issue for that?

## Errors per input

### Errors in content/en/policies/other/mitigate-log4shell/mitigate-log4shell.md

* [404] [https://logging.apache.org/log4j/2.x/security.html](https://logging.apache.org/log4j/2.x/security.html) | Failed: Network error: Not Found

### Errors in content/en/_index.md

* [ERR] [https://bestpractices.coreinfrastructure.org/projects/5327](https://bestpractices.coreinfrastructure.org/projects/5327) | Failed: Network error: error sending request for url (https://www.bestpractices.dev/projects/5327)
* [ERR] [https://bestpractices.coreinfrastructure.org/projects/5327/badge](https://bestpractices.coreinfrastructure.org/projects/5327/badge) | Failed: Network error: error sending request for url (https://www.bestpractices.dev/projects/5327/badge)

@JimBugwadia
Copy link
Member

Created #1340.

@JimBugwadia JimBugwadia merged commit 6117e89 into kyverno:main Sep 9, 2024
5 of 6 checks passed
Copy link

welcome bot commented Sep 9, 2024

Congratulations! 🎉

Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community.

200w

@dixudx dixudx deleted the install-doc-minor-update branch September 10, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants