Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit for the idea of Assigning Node Metadata to Pods #1344

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

abirsigron
Copy link
Contributor

Added credit for the idea of using kyverno for "Assigning Node Metadata to Pods"

Following my idea to use kyverno to add node metadata to pods using kyverno policy in the kyverno slack thread, including implementing the first POC

Copy link

welcome bot commented Sep 12, 2024

Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off.

Signed-off-by: abirsigron <[email protected]>
@abirsigron abirsigron changed the title Credit to Abir Sigron Credit for the idea of Assigning Node Metadata to Pods Sep 12, 2024
@realshuting realshuting self-requested a review September 23, 2024 13:43
@realshuting realshuting self-assigned this Sep 23, 2024
@realshuting
Copy link
Member

I'm not the author of this blog post, deferring it to @chipzoller .

@realshuting realshuting removed their assignment Sep 24, 2024
@realshuting realshuting removed their request for review September 24, 2024 06:38
@abirsigron
Copy link
Contributor Author

@chipzoller Can you approve and merge?

Signed-off-by: abirsigron <[email protected]>
@abirsigron
Copy link
Contributor Author

Hey @realshuting
The PR was approved by @chipzoller
Can you approve and merge please?

@JimBugwadia JimBugwadia merged commit 9ed98d6 into kyverno:main Oct 13, 2024
5 of 6 checks passed
Copy link

welcome bot commented Oct 13, 2024

Congratulations! 🎉

Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community.

200w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants