Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunrise, sunset, moonrise and moonset. #17

Open
thomasing opened this issue May 14, 2015 · 1 comment
Open

Sunrise, sunset, moonrise and moonset. #17

thomasing opened this issue May 14, 2015 · 1 comment

Comments

@thomasing
Copy link
Contributor

Proposed API functions:
time predict_sunrise(observer_, time, observation_)
time predict_sunset(observer_, time, observation_)
time predict_moonrise(observer_, time, observation_)
time predict_moonset(observer_, time, observation_)
All functions should use apparent elevation and correct for sun disk and moon disk diameter, such that sunrise happens at the moment the top of the sun disk is above the horizon. Functions should return the predicted time and fill observation pointer with observation data, if it is provided.

@ryeng ryeng added this to the 1.0.0 milestone May 15, 2015
@ryeng ryeng modified the milestones: 1.1.0, 1.0.0 Aug 29, 2015
@ryeng
Copy link
Contributor

ryeng commented Sep 23, 2015

I think we should have some more parameters to define which definition of sunrise/sunset is requested. See http://search.cpan.org/~jforget/Astro-Sunrise-0.95/lib/Astro/Sunrise.pm#DESCRIPTION for some definitions.

We can provide constants in header files for the most common ones.

@thomasing thomasing self-assigned this Sep 25, 2015
@ryeng ryeng modified the milestones: 2.0.0, 1.1.0 Oct 3, 2015
@ryeng ryeng closed this as completed Nov 25, 2017
@ryeng ryeng reopened this Nov 25, 2017
@ryeng ryeng removed this from the 2.0.0 milestone Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants