Added visibility status to struct predict_observation. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -287,6 +287,8 @@ struct predict_observation { | |||
| double range_x, range_y, range_z; | |||
| ///Range velocity (km/s) | |||
| double range_rate; | |||
| ///Visibility status, whether satellite can be seen through optical means | |||
There was a problem hiding this comment.
My understanding: The satellite is "visible" if all of these apply:
- The satellite is in sunlight
- The satellite is above the horizon
- The sun is low enough to make the sky so dark that the satellite is visible (this obviously depends on a definition of darkness)
The short description of the variable is OK, but I'd like to see a longer description containing all the details.
There was a problem hiding this comment.
I've written a longer comment (commit a41ccb8).
|
If we want several definitions of "dark enough", I think we'll need to make separate functions for this. See also #17 (comment). But I'm fine with the current solution for now if we create an issue to look at this in the future. |
ryeng
added a commit
that referenced
this pull request
Oct 5, 2015
Add visibility status to struct predict_observation. Closes #33.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new field to struct predict_observation. Will result in extra call to sun prediction within predict_observe_orbit, if that is acceptable. Otherwise, we could create a new function.