Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pretty print persisted log entries in CLI #151

Merged
merged 3 commits into from
Oct 6, 2024

Conversation

why-arong
Copy link
Contributor

@why-arong why-arong commented Oct 5, 2024

Implement pretty-print persisted log entries in a more readable table format using comfy-table

@jopemachine jopemachine added the cli label Oct 5, 2024
@jopemachine jopemachine added feature New feature or request log-storage Log store (Stable storage) labels Oct 5, 2024
@jopemachine jopemachine changed the title feat: add table formatting feature feat: Pretty print persisted log entries in CLI Oct 5, 2024
@jopemachine jopemachine marked this pull request as ready for review October 6, 2024 01:55
@jopemachine
Copy link
Member

Due to the lack of autowrap functionality, we have decided to use the comfy-table crate instead of prettytable-rs.

@jopemachine
Copy link
Member

Thanks!

@jopemachine jopemachine merged commit aa7b3a7 into lablup:main Oct 6, 2024
5 checks passed
@why-arong why-arong deleted the table-format branch October 6, 2024 13:44
@jopemachine jopemachine added the ossca-24 OSS Contribution Academy mentee's contributions. label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli feature New feature or request log-storage Log store (Stable storage) ossca-24 OSS Contribution Academy mentee's contributions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants