Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enhance .gitignore handling using 'git ls-files' #16

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix: Enhance .gitignore handling using 'git ls-files' #16

merged 1 commit into from
Dec 22, 2023

Conversation

pawanpaudel93
Copy link
Contributor

Summary

  • Use git ls-files to get the files to upload ignoring files from .gitignore

@pawanpaudel93 pawanpaudel93 requested a review from 7i7o December 20, 2023 16:29
7i7o
7i7o approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@7i7o 7i7o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK
It's working perfectly! Even using negating patterns in nested .gitignore files 👍

LGTM! 🚀

@pawanpaudel93 pawanpaudel93 merged commit 471332f into main Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7i7o 7i7o 7i7o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawanpaudel93 @7i7o