-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ProjectivePoint
from types-rs in ec_op builtin impl
#1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
==========================================
- Coverage 97.21% 97.21% -0.01%
==========================================
Files 90 90
Lines 36464 36454 -10
==========================================
- Hits 35449 35439 -10
Misses 1015 1015 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
fmoletta
changed the title
[WIP] Use
Use Jan 4, 2024
ProjectivePoint
from types-rs in ec_op builtin implProjectivePoint
from types-rs in ec_op builtin impl
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono and
pefontana
as code owners
January 4, 2024 16:22
Oppen
previously approved these changes
Jan 4, 2024
…ss/cairo-vm into ec-op-projective-types-rs-impl
Oppen
reviewed
Jan 5, 2024
Oppen
previously approved these changes
Jan 5, 2024
Co-authored-by: Mario Rugiero <[email protected]>
Oppen
approved these changes
Jan 5, 2024
pefontana
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use types-rs
ProjectivePoint
implementation (aka lambdaworks implementation) for ec_op builtin operationsPending:
starknet-core-types
version