Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ProjectivePoint from types-rs in ec_op builtin impl #1532

Merged
merged 15 commits into from
Jan 5, 2024

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Jan 2, 2024

Use types-rs ProjectivePoint implementation (aka lambdaworks implementation) for ec_op builtin operations
Pending:

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88a5bf1) 97.21% compared to head (0a47ca2) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
- Coverage   97.21%   97.21%   -0.01%     
==========================================
  Files          90       90              
  Lines       36464    36454      -10     
==========================================
- Hits        35449    35439      -10     
  Misses       1015     1015              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.249 ± 0.009 2.240 2.269 1.04 ± 0.01
head big_factorial 2.167 ± 0.018 2.148 2.200 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.253 ± 0.049 2.218 2.384 1.05 ± 0.03
head big_fibonacci 2.154 ± 0.031 2.130 2.235 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.225 ± 0.060 8.154 8.334 1.05 ± 0.01
head blake2s_integration_benchmark 7.853 ± 0.067 7.790 7.948 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.277 ± 0.027 2.257 2.343 1.03 ± 0.01
head compare_arrays_200000 2.214 ± 0.017 2.196 2.235 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.445 ± 0.012 1.434 1.475 1.03 ± 0.01
head dict_integration_benchmark 1.403 ± 0.015 1.390 1.439 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.283 ± 0.008 1.273 1.302 1.03 ± 0.01
head field_arithmetic_get_square_benchmark 1.251 ± 0.013 1.235 1.274 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.226 ± 0.052 8.187 8.364 1.05 ± 0.01
head integration_builtins 7.857 ± 0.065 7.799 7.964 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.495 ± 0.071 8.428 8.635 1.04 ± 0.01
head keccak_integration_benchmark 8.140 ± 0.070 8.060 8.249 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.301 ± 0.012 2.286 2.322 1.02 ± 0.01
head linear_search 2.245 ± 0.031 2.214 2.309 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.576 ± 0.004 1.570 1.582 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.559 ± 0.028 1.539 1.629 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.425 ± 0.007 1.414 1.438 1.01 ± 0.01
head math_integration_benchmark 1.416 ± 0.011 1.404 1.434 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.254 ± 0.005 1.249 1.261 1.02 ± 0.01
head memory_integration_benchmark 1.225 ± 0.008 1.219 1.241 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.601 ± 0.011 1.591 1.629 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.580 ± 0.007 1.570 1.593 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 608.7 ± 5.8 604.1 624.5 1.02 ± 0.01
head pedersen 598.8 ± 2.5 595.5 603.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.063 ± 0.004 1.060 1.072 1.01 ± 0.01
head poseidon_integration_benchmark 1.056 ± 0.006 1.051 1.068 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.968 ± 0.002 1.965 1.972 1.04 ± 0.00
head secp_integration_benchmark 1.891 ± 0.006 1.882 1.905 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 754.2 ± 3.1 751.2 761.4 1.01 ± 0.01
head set_integration_benchmark 744.1 ± 3.6 741.0 753.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.562 ± 0.036 4.506 4.612 1.04 ± 0.01
head uint256_integration_benchmark 4.370 ± 0.028 4.343 4.413 1.00

@fmoletta fmoletta changed the title [WIP] Use ProjectivePoint from types-rs in ec_op builtin impl Use ProjectivePoint from types-rs in ec_op builtin impl Jan 4, 2024
@fmoletta fmoletta marked this pull request as ready for review January 4, 2024 16:21
Oppen
Oppen previously approved these changes Jan 4, 2024
vm/src/vm/runners/builtin_runner/ec_op.rs Outdated Show resolved Hide resolved
vm/src/vm/runners/builtin_runner/ec_op.rs Outdated Show resolved Hide resolved
Oppen
Oppen previously approved these changes Jan 5, 2024
@pefontana pefontana added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit 42a652c Jan 5, 2024
50 checks passed
@pefontana pefontana deleted the ec-op-projective-types-rs-impl branch January 5, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants