feat(levm): implement Transaction Report #930
Conversation
JereSalo
changed the title
JereSalo
changed the title
| &mut self, | ||
| current_call_frame: &mut CallFrame, | ||
| ) -> Result<OpcodeSuccess, VMError> { | ||
| pub fn execute(&mut self, current_call_frame: &mut CallFrame) -> TransactionReport { |
There was a problem hiding this comment.
Shouldn't transact return a TransactionReport instead? execute is supposed to be called only from inside of VM.
There was a problem hiding this comment.
I've just seen that transact is indeed returning a TransactionReport, but do you think execute should be returning the same?
There was a problem hiding this comment.
Yeah it may not be the most accurate representation but it makes it more simple to use the same, the attributes we need in both scenarios are almost identical.
Maybe the other option would be to have another struct for that purpose (ContextResult?) and then on transact we should execute the VM and generate the TransactionReport based on the ContextResult returned by execute and the final state of the VM. It doesn't sound like a bad idea.
Let me know what you think.
Motivation
Implement interface transaction report and make call work with it.
Description
returndata. Createdsub_return_datafor subcontext and left return_data for current context.RETURNDATASIZEandRETURNDATACOPYto usesub_return_dataOut of scope but implemented:
Closes #926
Closes #923 - partially addressed, there are still changes to make to
generic_call()Closes #922
Closes #938 - Even though this issue is out of scope, the fix was only a one line change.