-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bn254 sqrt and decompression #905
Conversation
math/src/elliptic_curve/short_weierstrass/curves/bn_254/sqrt.rs
Outdated
Show resolved
Hide resolved
math/src/elliptic_curve/short_weierstrass/curves/bn_254/sqrt.rs
Outdated
Show resolved
Hide resolved
math/src/elliptic_curve/short_weierstrass/curves/bn_254/sqrt.rs
Outdated
Show resolved
Hide resolved
math/src/elliptic_curve/short_weierstrass/curves/bn_254/sqrt.rs
Outdated
Show resolved
Hide resolved
math/src/elliptic_curve/short_weierstrass/curves/bls12_381/compression.rs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 72.72% 73.03% +0.30%
==========================================
Files 150 152 +2
Lines 34498 34936 +438
==========================================
+ Hits 25090 25514 +424
- Misses 9408 9422 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Select the root in the sqrt_qfe function accordingly.
BN254 Curve sqrt and decompression
Description
Add a square root function for quadratic extension and a point decompression function for the BN254 Curve. We left some TODOs because we need to check why we always have to set
sqrt_qfe
input to 0 for tests to pass.Type of change