Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bn254 sqrt and decompression #905

Merged
merged 25 commits into from
Sep 13, 2024
Merged

Conversation

nicole-graus
Copy link
Contributor

BN254 Curve sqrt and decompression

Description

Add a square root function for quadratic extension and a point decompression function for the BN254 Curve. We left some TODOs because we need to check why we always have to set sqrt_qfe input to 0 for tests to pass.

Type of change

  • New feature

@nicole-graus nicole-graus requested a review from a team as a code owner September 5, 2024 14:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 93.91892% with 27 lines in your changes missing coverage. Please review.

Project coverage is 73.03%. Comparing base (28e2cdd) to head (4193540).

Files with missing lines Patch % Lines
...rve/short_weierstrass/curves/bn_254/compression.rs 96.02% 11 Missing ⚠️
...ptic_curve/short_weierstrass/curves/bn_254/sqrt.rs 92.71% 11 Missing ⚠️
...tic_curve/short_weierstrass/curves/bn_254/curve.rs 0.00% 3 Missing ⚠️
.../short_weierstrass/curves/bls12_381/compression.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   72.72%   73.03%   +0.30%     
==========================================
  Files         150      152       +2     
  Lines       34498    34936     +438     
==========================================
+ Hits        25090    25514     +424     
- Misses       9408     9422      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@diegokingston diegokingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select the root in the sqrt_qfe function accordingly.

@diegokingston diegokingston added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 2787f65 Sep 13, 2024
7 checks passed
@diegokingston diegokingston deleted the add-bn254-point-decompression branch September 13, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants