Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hydrators key to extractors #14

Open
weierophinney opened this issue Dec 31, 2019 · 4 comments
Open

Rename hydrators key to extractors #14

weierophinney opened this issue Dec 31, 2019 · 4 comments

Comments

@weierophinney
Copy link
Contributor

Would it not be better to rename the hydrators key to extractors. In the whole zf-hal (or any other related) module the hydrators are never used for hydration but merely for extraction. So the name of this key is only confusing IMO.

I understand this can be a BC issue, but maybe it can be changed in version 2.0?


Originally posted by @Wilt at zfcampus/zf-hal#128

@weierophinney
Copy link
Contributor Author

Not sure why @boesing closed this issue...

I am talking about the key mentioned here in the docs: https://github.com/zfcampus/zf-hal#key-renderer

'zf-hal' => array(
    'renderer' => arrray(
        'hydrators' => array(
        )
    )
)

It is a map for rendering (so extracting) objects, not hydrating them...


Originally posted by @Wilt at zfcampus/zf-hal#128 (comment)

@weierophinney
Copy link
Contributor Author

I did not close this. As you can see, I've just closed #132 after 2 years. I don't like issues or PR which are open for more than 2 years tho.


Originally posted by @boesing at zfcampus/zf-hal#128 (comment)

@weierophinney
Copy link
Contributor Author

My bad. Sorry for this...

I agree, it is not good to keep thinks pending for so long, but didn't get any feedback on this and still think it would make sense to rename this key. I could make a PR for this myself though, but before I put time in this I would like to know if the contributors think it would make sense to make such a change.


Originally posted by @Wilt at zfcampus/zf-hal#128 (comment)

@weierophinney
Copy link
Contributor Author

Here is a hydrator used to hydrate:
https://github.com/zfcampus/zf-apigility-doctrine/blob/master/src/Server/Resource/DoctrineResource.php#L345

I strongly disagree with changing the key


Originally posted by @TomHAnderson at zfcampus/zf-hal#128 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant