-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename hydrators
key to extractors
#14
Comments
Not sure why @boesing closed this issue... I am talking about the key mentioned here in the docs: https://github.com/zfcampus/zf-hal#key-renderer
It is a map for rendering (so extracting) objects, not hydrating them... Originally posted by @Wilt at zfcampus/zf-hal#128 (comment) |
I did not close this. As you can see, I've just closed #132 after 2 years. I don't like issues or PR which are open for more than 2 years tho. Originally posted by @boesing at zfcampus/zf-hal#128 (comment) |
My bad. Sorry for this... I agree, it is not good to keep thinks pending for so long, but didn't get any feedback on this and still think it would make sense to rename this key. I could make a PR for this myself though, but before I put time in this I would like to know if the contributors think it would make sense to make such a change. Originally posted by @Wilt at zfcampus/zf-hal#128 (comment) |
Here is a hydrator used to hydrate: I strongly disagree with changing the key Originally posted by @TomHAnderson at zfcampus/zf-hal#128 (comment) |
Would it not be better to rename the
hydrators
key toextractors
. In the whole zf-hal (or any other related) module the hydrators are never used for hydration but merely for extraction. So the name of this key is only confusing IMO.I understand this can be a BC issue, but maybe it can be changed in version 2.0?
Originally posted by @Wilt at zfcampus/zf-hal#128
The text was updated successfully, but these errors were encountered: