Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Rename hydrators key to extractors #128

Open
Wilt opened this issue Oct 22, 2015 · 5 comments
Open

Rename hydrators key to extractors #128

Wilt opened this issue Oct 22, 2015 · 5 comments

Comments

@Wilt
Copy link
Contributor

Wilt commented Oct 22, 2015

Would it not be better to rename the hydrators key to extractors. In the whole zf-hal (or any other related) module the hydrators are never used for hydration but merely for extraction. So the name of this key is only confusing IMO.

I understand this can be a BC issue, but maybe it can be changed in version 2.0?

@Wilt
Copy link
Contributor Author

Wilt commented Aug 16, 2017

Not sure why @boesing closed this issue...

I am talking about the key mentioned here in the docs: https://github.com/zfcampus/zf-hal#key-renderer

'zf-hal' => array(
    'renderer' => arrray(
        'hydrators' => array(
        )
    )
)

It is a map for rendering (so extracting) objects, not hydrating them...

@boesing
Copy link

boesing commented Aug 16, 2017

I did not close this. As you can see, I've just closed #132 after 2 years. I don't like issues or PR which are open for more than 2 years tho.

@Wilt
Copy link
Contributor Author

Wilt commented Aug 18, 2017

My bad. Sorry for this...

I agree, it is not good to keep thinks pending for so long, but didn't get any feedback on this and still think it would make sense to rename this key. I could make a PR for this myself though, but before I put time in this I would like to know if the contributors think it would make sense to make such a change.

@TomHAnderson
Copy link
Contributor

Here is a hydrator used to hydrate:
https://github.com/zfcampus/zf-apigility-doctrine/blob/master/src/Server/Resource/DoctrineResource.php#L345

I strongly disagree with changing the key

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas-api-tools/api-tools-hal; a new issue has been opened at laminas-api-tools/api-tools-hal#14.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants