Remove IbmDb2 Adapter #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
approved these changes
Apr 9, 2020
weierophinney
approved these changes
Apr 9, 2020
Signed-off-by: Alex Denvir <[email protected]>
Signed-off-by: Alex Denvir <[email protected]>
weierophinney
force-pushed
the
remove-ibm-db2-adapter
branch
from
9097c2e
to
d02fb1f
Compare
weierophinney
added a commit
that referenced
this pull request
Sep 10, 2020
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes IbmDb2 Adapter.
This is basically just a copy of zfcampus/zf-oauth2#168 which was never merged, so credit should go to @michalbundyra. As per the original PR, the IbmDb2 storage is not in the oauth2 library, and never has been. The original PR to add this storage to the oauth2 library was opened in 2015, and last updated 2017.
I don't think this is a BC break, but it is removing a class regardless so maybe thats a judgement call for maintainers?
Fixes #3, and fixes broken tests with coverage (
with my recently merged PR, builds should start passing again!cs checks still fail 😢)