Adjust packages and extensions in order to run on PHP 8.0 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giannicic But updating the Docker file is also good. |
froschdesign
reviewed
May 5, 2022
Closed
Signed-off-by: Gianni Ciccarelli <[email protected]>
Ah ok, sorry. I haven't seen that composer works with --ignore-platform-req=php. I was following the instructions here https://api-tools.getlaminas.org/ and on PHP8 it gives the same errors reported in #44 |
Ocramius
approved these changes
May 6, 2022
| && a2enmod rewrite \ | ||
| && sed -i 's!/var/www/html!/var/www/public!g' /etc/apache2/sites-available/000-default.conf \ | ||
| && mv /var/www/html /var/www/public \ | ||
| && curl -sS https://getcomposer.org/installer \ | ||
| | php -- --install-dir=/usr/local/bin --filename=composer \ | ||
| && curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer \ |
There was a problem hiding this comment.
Not important, but we should probably use multi-stage here, pinning composer to a specific version:
FROM composer:2.3.3 AS get-composer
FROM php:8.0-apache
COPY --from=get-composer /usr/local/bin/composer /usr/local/bin/composerThere was a problem hiding this comment.
Ok, I'll try it and create a PR then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've seen that the project skeleton can't run on PHP-8.0 as reported here #44
Since I also have the need to run a new project on PHP-8.0 I've adjusted the composer packages and Dockerfile in order to run on that version.
Hope you find it usefull