Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Return include fields when one of them is empty #2044

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

sunnyosun
Copy link
Member

@sunnyosun sunnyosun commented Oct 11, 2024

Print warning for no-value columns in df include:
Screenshot 2024-10-11 at 14 21 25

@sunnyosun sunnyosun changed the title 🔊 Print warning for no-value columns in df include 🐛 Print warning for no-value columns in df include Oct 11, 2024
@sunnyosun sunnyosun changed the title 🐛 Print warning for no-value columns in df include 🐛 Return include fields when one of them is empty Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.38%. Comparing base (80fb3b0) to head (9c94aae).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/_query_set.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
- Coverage   92.39%   92.38%   -0.02%     
==========================================
  Files          54       54              
  Lines        6341     6342       +1     
==========================================
  Hits         5859     5859              
- Misses        482      483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunnyosun sunnyosun merged commit cc0a0a3 into main Oct 11, 2024
13 of 15 checks passed
@sunnyosun sunnyosun deleted the fix-df-include branch October 11, 2024 12:28
Copy link

@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 12:29 Inactive
@andreassteffen
Copy link

thank you so much! Will test later.

@sunnyosun
Copy link
Member Author

More fixes and tests here: #2045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants