Renamed cache_mem_size to cache_index_size #103
Conversation
| @@ -4,9 +4,16 @@ set -e | |||
| # Preprocess UPSTREAM_DNS to allow for multiple resolvers using the same syntax as lancache-dns | |||
| UPSTREAM_DNS="$(echo -n "${UPSTREAM_DNS}" | sed 's/[;]/ /g')" | |||
|
|
|||
| if [ ! -z ${CACHE_MEM_SIZE} ]; then | |||
There was a problem hiding this comment.
As per monolithic this should be done in a deprecation file so all the checks happen in the same place (I'd perhaps suggest 00_generic_deprecation.sh to avoid naming clashes)
There was a problem hiding this comment.
At the moment it can probably just warning rather than error, then EXPORT CACHE_INDEX_SIZE up to the controlling shell?
There was a problem hiding this comment.
I'm not sure you can export a variable from one script to the parent shell - unless this is a magic bit of supervisord functionality?
Could move the warning out to a separate script, and leave the action in place?
There was a problem hiding this comment.
Kinda forgot about this!
I think the best option with fresh eyes is to do the transfer here so it can be used in the script, and then put the warning message into deprecation.sh but without the abort so it will stilll continue for the moment.
We would also need to update the website and docker-compose (I don't think we have PR's waiting for those do we?
Ported PR lancachenet/generic#103 from @Crabbey Changes CACHE_MEM_SIZE to CACHE_INDEX_SIZE but maintains backwards compatiblity through deprecation.sh
Rebasing generic off monolithic Includes lancachenet/generic#103 lancachenet/generic#93 lancachenet/generic#113 lancachenet/generic#108 Thanks to @Crabbey @zerotacg @csm10495 and @Candunc
|
Merged via lancachenet/monolithic#133 |
No description provided.