prevent multiple requests while filling the cache #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VibroAxe
added a commit
to lancachenet/monolithic
that referenced
this pull request
Oct 9, 2021
This allows us to cache the response in the event a file hasn't been downloaded yet Set to 2m as a really long time to download a single 1m slice from upstream Based on thoughts from lancachenet/generic#113
VibroAxe
added a commit
to lancachenet/monolithic
that referenced
this pull request
Oct 9, 2021
Rebasing generic off monolithic Includes lancachenet/generic#103 lancachenet/generic#93 lancachenet/generic#113 lancachenet/generic#108 Thanks to @Crabbey @zerotacg @csm10495 and @Candunc
|
Updated and Merged via lancachenet/monolithic#133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while proxy_cache_lock_timeout is set to ensure the request is cached, there still can happen multiple requests to the origin server while the entry is being cached. This would result in reduced bandwidth for the proxy itself.
[0] https://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_cache_lock_age