Skip to content

Commit

Permalink
Remove xfail from passing integration tests. (#232)
Browse files Browse the repository at this point in the history
Some of the tests marked `xfail` are passing in my local testing.
Enabling them, so these run during the release.

```shell
tests/integration_tests/chat_models/test_standard.py::TestBedrockStandard::test_tool_message_histories_string_content PASSED
tests/integration_tests/chat_models/test_standard.py::TestBedrockStandard::test_tool_message_histories_list_content PASSED
tests/integration_tests/chat_models/test_standard.py::TestBedrockStandard::test_structured_few_shot_examples PASSED
```
  • Loading branch information
3coins authored Oct 17, 2024
1 parent 902252b commit 09eef16
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions libs/aws/tests/integration_tests/chat_models/test_standard.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,6 @@ def standard_chat_model_params(self) -> dict:
def test_stop_sequence(self, model: BaseChatModel) -> None:
super().test_stop_sequence(model)

@pytest.mark.xfail(reason="Not yet implemented.")
def test_tool_message_histories_string_content(self, model: BaseChatModel) -> None:
super().test_tool_message_histories_string_content(model)

@pytest.mark.xfail(reason="Not yet implemented.")
def test_tool_message_histories_list_content(self, model: BaseChatModel) -> None:
super().test_tool_message_histories_list_content(model)

@pytest.mark.xfail(reason="Not yet implemented.")
def test_structured_few_shot_examples(
self,
model: BaseChatModel,
) -> None:
super().test_structured_few_shot_examples(model)


class TestBedrockUseConverseStandard(ChatModelIntegrationTests):
@property
Expand Down

0 comments on commit 09eef16

Please sign in to comment.