Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws[patch]: set defaults on DocumentAttributeValue #203

Merged
merged 2 commits into from
Sep 19, 2024
Merged

aws[patch]: set defaults on DocumentAttributeValue #203

merged 2 commits into from
Sep 19, 2024

Conversation

ccurme
Copy link
Contributor

@ccurme ccurme commented Sep 19, 2024

Resolves #202

@ccurme ccurme mentioned this pull request Sep 19, 2024
Closed
@supreetkt
Copy link

supreetkt commented Sep 19, 2024 •
edited
Loading

Thanks for a quick PR. I'm also assuming that you should add it for other optional fields which is not done yet. For example, ResultItem, etc. @ccurme

@ccurme
Copy link
Contributor Author

ccurme commented Sep 19, 2024

Thanks for a quick PR. I'm also assuming that you should add it for other optional fields which is not done yet. For example, ResultItem, etc. @ccurme

Thanks, should be all set.

@supreetkt
Copy link

Great! Looks good to me @3coins

@ccurme ccurme merged commit 151125b into main Sep 19, 2024
12 checks passed
@ccurme ccurme deleted the cc/fix_DocumentAttributeValue branch September 19, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kendra queries are failing with langchain update
2 participants
@ccurme @supreetkt