Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohere can specify models #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yhfgyyf
Copy link

@yhfgyyf yhfgyyf commented Jul 11, 2024

Fixed the bug where “from langchain_cohere.llms import Cohere”,Cohere could not specify models.

Fixed the bug where “from langchain_cohere.llms import Cohere”,Cohere could not specify models.

Signed-off-by: yhfgyyf <[email protected]>
@Anirudh31415926535
Copy link
Collaborator

Hi @yhfgyyf Thanks so much for the PR!
Just so that I understand better, could you maybe provide an example code snippet that works now after this PR, but not before?
Also, please do add a unit test for this change in /libs/cohere/tests/unit_tests/test_llm.py.

@yhfgyyf
Copy link
Author

yhfgyyf commented Jul 12, 2024

from langchain_cohere.llms import Cohere llm = Cohere(model="command",cohere_api_key=cohere_key,temperature=0) llm.invoke("hello")
fix the issue #44

@Anirudh31415926535
Copy link
Collaborator

@yhfgyyf Hi, got it, the fix looks good! Could you please just add the unit test in? We can merge it after that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants