[vertexai] Fix Datastore error on indexing large fields #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `self._text_property_name` might contain large text, this fix prevents from indexing a large field like a document corpus. This also saves datastore's costs, preventing a non necessary field to be indexed.
lspataroG
changed the title
lkuligin
approved these changes
Oct 18, 2024
lspataroG
changed the title
lkuligin
reviewed
Oct 26, 2024
libs/vertexai/langchain_google_vertexai/vectorstores/document_storage.py
Outdated
Show resolved
Hide resolved
lkuligin
reviewed
Oct 26, 2024
libs/vertexai/langchain_google_vertexai/vectorstores/vectorstores.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
self._text_property_nameand other fields might contain large text, this fix prevents from indexing such fields that currently triggers an error (see Datastores's maximum size of an indexed string property limitation). This also saves datastore's costs, preventing a non necessary field to be indexed. We can now pass a listexclude_from_indexesto the class, which is the same list that the sdk expects in input when creating an entity.🐛 Bug Fix