openai[patch]: change in client_params via config updates the client

[spike-spiegel-21]

Description: Changes in client parameters can be done using ConfigurableFields
Issue: note: There might be more related issues.
fixes: #23381 (langchain-ai/langserve#693) (langchain-ai/langserve#652)
Twitter handle: @mynksol

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchain	⬜️ Ignored (Inspect)	Visit Preview		Jul 8, 2024 6:07pm

[quadcube]

@spike-spiegel-21 hey there! thank you for working on the patch.
I have tested your fix (mainly removal of the 'values.get("client")' and it's async equivalent), it works fine on my end and fixed the problem

[quadcube]

On further testing, this works for regular chain invoke but it seems that it does not work for agents.
May be related to these:
langchain-ai/langserve#314
#17555

[spike-spiegel-21]

Noted @quadcube This PR was intended to solve the issue only for the langchain_openai chat model. I will raise a separate PR for:
langchain-ai/langserve#314
#17555

[quadcube]

@spike-spiegel-21 if it's helpful, I can open an issue with the code to reproduce the problem for the configurable agent.

[spike-spiegel-21]

@spike-spiegel-21 if it's helpful, I can open an issue with the code to reproduce the problem for the configurable agent.

@quadcube Thank You!

[spike-spiegel-21]

@baskaryan @efriis Please have a look. I came up with the best resolution after debugging

[efriis]

this is currently a breaking change for a few cases (including the ones that are failing tests, as well as anyone manually passing in client or async_client)

the case you want to fix is just adding configurability to the openai_api_key?

going to mark this as a draft while we sort out the best way to do this

[efriis]

closing as stale - let me know if you have thoughts above!