milvus: add_db_milvus_connection

[venkatram-dev]

Thank you for contributing to LangChain!

• PR title: "package: description"

  • Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
  • Example: "community: add foobar LLM"
  • "libs: langchain_milvus: add db name to milvus connection check"

• PR message: Delete this entire checklist and replace with

  • Description: add db name to milvus connection check
  • Issue: Langchain Milvus - Handle switch between multiple databases #25277

• Add tests and docs: If you're adding a new integration, please include

  1. a test for the integration, preferably unit tests that do not rely on network access,
  2. an example notebook showing its use. It lives in docs/docs/integrations directory.

• Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

• Make sure optional dependencies are imported within a function.
• Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
• Most PRs should not touch more than one package.
• Changes should be backwards compatible.
• If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchain	⬜️ Ignored (Inspect)	Visit Preview		Aug 26, 2024 5:26pm

[venkatram-dev]

@baskaryan , made a commit to fix linting errors. Please retry the CI checks.

[zc277584121]

LGTM

[hasansustcse13]

This problem was reported by me in Milvus. This fix now create new instance every time as milvus team doesn't provide db_name in the connection list yet. I am wondering why this pr has been merged despite dependency of milvus.
milvus-io/pymilvus#2161
@efriis

[efriis]

hey! if there are outstanding issues, please open them against the https://github.com/langchain-ai/langchain-milvus repo, which is primarily maintained by the milvus team including @zc277584121 who approved this PR

[hasansustcse13]

@efriis First Pymilvus team need to adjust the problem. Then We can integrate in langchain/ langchain milvus (which already done in this pr) . I have reported this a long time ago but they didn't fix it. That's why I have made a merge request in milvus-io. Let's see when they merge it

milvus-io/pymilvus#2285