Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Implement types for Pregel.stream using recursive type #512

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

WIP: Implement types for Pregel.stream using recursive type #512

wants to merge 16 commits into from

Commits on Sep 24, 2024

  1. WIP: Implement types for Pregel.stream using recursive type

    @nfcampos
    nfcampos committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f6b1d52 View commit details
    Browse the repository at this point in the history

  2. no longer excessively deep nor possibly infinite

    @Masstronaut
    Masstronaut committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7b24c92 View commit details
    Browse the repository at this point in the history

  3. specified debug output type

    @Masstronaut
    Masstronaut committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    92184d1 View commit details
    Browse the repository at this point in the history

  4. all tests passing!

    @Masstronaut
    Masstronaut committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    24eb241 View commit details
    Browse the repository at this point in the history

  5. all tests passing!

    @Masstronaut
    Masstronaut committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    278517c View commit details
    Browse the repository at this point in the history

  6. formatting

    @Masstronaut
    Masstronaut committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a387043 View commit details
    Browse the repository at this point in the history

  7. cleared out StrRecord type

    @Masstronaut
    Masstronaut committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6cb8766 View commit details
    Browse the repository at this point in the history

  8. clearer type parameters for channels and nodes

    @Masstronaut
    Masstronaut committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7773c04 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. need to type the values stored in pregel loop

    @Masstronaut
    Masstronaut committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7423be5 View commit details
    Browse the repository at this point in the history

  2. formatting

    @Masstronaut
    Masstronaut committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    75af108 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Only invoke remains!

    @Masstronaut
    Masstronaut committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ab4e684 View commit details
    Browse the repository at this point in the history

  2. invoke maybe array return type

    @Masstronaut
    Masstronaut committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9dafb44 View commit details
    Browse the repository at this point in the history

  3. invoke return type needs narrowing still

    @Masstronaut
    Masstronaut committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    aed73d9 View commit details
    Browse the repository at this point in the history

  4. Invoke return types are happy

    @Masstronaut
    Masstronaut committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9dd5bc5 View commit details
    Browse the repository at this point in the history

  5. Swapped return type to use ChannelStateType

    @Masstronaut
    Masstronaut committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    cd5a085 View commit details
    Browse the repository at this point in the history

  6. Return typing for invoke & stream 

    Still returns unknown, which is derived from the `Channels` generic param. Channels are stored everywhere as `Record<string, BaseChannel>` which types the channel value & updates as unknown. Need to figure out a way to reintegrate channel types throughout to narrow the return type further.
    @Masstronaut
    Masstronaut authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1342d59 View commit details
    Browse the repository at this point in the history