Skip to content

Commit

Permalink
[Python] push_prompt update (#1202)
Browse files Browse the repository at this point in the history
Make is_public optional to avoid hiding public prompts unintentonally
  • Loading branch information
hinthornw authored Nov 11, 2024
1 parent 2bf4569 commit 5d5cace
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
12 changes: 7 additions & 5 deletions python/langsmith/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -5611,7 +5611,7 @@ def push_prompt(
*,
object: Optional[Any] = None,
parent_commit_hash: str = "latest",
is_public: bool = False,
is_public: Optional[bool] = None,
description: Optional[str] = None,
readme: Optional[str] = None,
tags: Optional[Sequence[str]] = None,
Expand All @@ -5628,7 +5628,10 @@ def push_prompt(
object (Optional[Any]): The LangChain object to push.
parent_commit_hash (str): The parent commit hash.
Defaults to "latest".
is_public (bool): Whether the prompt should be public. Defaults to False.
is_public (Optional[bool]): Whether the prompt should be public.
If None (default), the current visibility status is maintained for existing prompts.
For new prompts, None defaults to private.
Set to True to make public, or False to make private.
description (Optional[str]): A description of the prompt.
Defaults to an empty string.
readme (Optional[str]): A readme for the prompt.
Expand All @@ -5643,8 +5646,7 @@ def push_prompt(
# Create or update prompt metadata
if self._prompt_exists(prompt_identifier):
if any(
param is not None
for param in [parent_commit_hash, is_public, description, readme, tags]
param is not None for param in [is_public, description, readme, tags]
):
self.update_prompt(
prompt_identifier,
Expand All @@ -5656,7 +5658,7 @@ def push_prompt(
else:
self.create_prompt(
prompt_identifier,
is_public=is_public,
is_public=is_public if is_public is not None else False,
description=description,
readme=readme,
tags=tags,
Expand Down
6 changes: 3 additions & 3 deletions python/tests/unit_tests/test_run_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,9 @@ def my_stream_fn(a, b, d, **kwargs):
]
first_patch = next((d for d in call_data if d.get("patch")), None)
attempt += 1

assert first_patch["name"] == "my_stream_fn"
assert first_patch[0]["outputs"] == {"my_output": expected}
if "name" in first_patch:
assert first_patch["name"] == "my_stream_fn"
assert first_patch[0]["outputs"] == {"my_output": expected}


@pytest.mark.parametrize("use_next", [True, False])
Expand Down

0 comments on commit 5d5cace

Please sign in to comment.