Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): Remove focused test, fix tests #1138

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix(js): Remove focused test, fix tests #1138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e57d90
Remove focused test
jacoblee93 Oct 27, 2024
609ac8c
Fix test
jacoblee93 Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions js/src/tests/batch_client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ describe.each(ENDPOINT_TYPES)(
await new Promise((resolve) => setTimeout(resolve, 300));
});

it.only("Create + update batching should merge into a single call", async () => {
it("Create + update batching should merge into a single call", async () => {
const client = new Client({
apiKey: "test-api-key",
autoBatchTracing: true,
Expand Down Expand Up @@ -298,7 +298,7 @@ describe.each(ENDPOINT_TYPES)(
end_time: endTime,
});

await new Promise((resolve) => setTimeout(resolve, 100));
await client.awaitPendingTraceBatches();

expect(serverInfoFailedOnce).toBe(true);

Expand Down Expand Up @@ -857,7 +857,7 @@ describe.each(ENDPOINT_TYPES)(
end_time: endTime,
});

await new Promise((resolve) => setTimeout(resolve, 100));
await client.awaitPendingTraceBatches();

const calledRequestParam: any = callSpy.mock.calls[0][2];
expect(await parseMockRequestBody(calledRequestParam?.body)).toEqual({
Expand Down
Loading