add upset examples multipart endpoint #1209
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agola11
reviewed
Nov 13, 2024
python/langsmith/client.py
Outdated
Comment on lines
3442
to
3446
| if encoder.len <= 20_000_000: # ~20 MB | ||
| data = encoder.to_string() | ||
| else: | ||
| data = encoder | ||
|
|
There was a problem hiding this comment.
I'm assuming this is what we do for runs?
There was a problem hiding this comment.
yeah this code was copy pasted
agola11
reviewed
Nov 13, 2024
python/langsmith/client.py
Outdated
| def upsert_examples_multipart( | ||
| self, | ||
| *, | ||
| upserts: List[ls_schemas.ExampleCreateWithAttachments] = [], |
There was a problem hiding this comment.
should not initialize this to empty list due to the way python handles mutable default arguments, see here https://nikos7am.com/posts/mutable-default-arguments/
to fix, just remove the default
agola11
reviewed
Nov 13, 2024
python/langsmith/client.py
Outdated
Comment on lines
3380
to
3384
| if not isinstance(upserts, list): | ||
| raise TypeError(f"upserts must be a list, got {type(upserts)}") | ||
| for item in upserts: | ||
| if not isinstance(item, ls_schemas.ExampleCreateWithAttachments): | ||
| raise TypeError(f"Each item must be ExampleCreateWithAttachments, got {type(item)}") |
There was a problem hiding this comment.
not necessary, we don't check types like this elsewhere
agola11
reviewed
Nov 13, 2024
agola11
reviewed
Nov 14, 2024
| ) | ||
|
|
||
| with pytest.raises(LangSmithNotFoundError): | ||
| langchain_client.upsert_examples_multipart(upserts=[example_3]) |
There was a problem hiding this comment.
why should this raise a not found?
There was a problem hiding this comment.
because it can't find the dataset I believe
Co-authored-by: Ankush Gola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.