Skip to content

Commit

Permalink
fix(file_factory): validate upload_file_id format as UUID (#12084)
Browse files Browse the repository at this point in the history
Signed-off-by: -LAN- <[email protected]>
  • Loading branch information
laipz8200 authored Dec 25, 2024
1 parent 50b7ec3 commit 754791e
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions api/factories/file_factory.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import mimetypes
import uuid
from collections.abc import Callable, Mapping, Sequence
from typing import Any, cast

Expand Down Expand Up @@ -119,6 +120,11 @@ def _build_from_local_file(
upload_file_id = mapping.get("upload_file_id")
if not upload_file_id:
raise ValueError("Invalid upload file id")
# check if upload_file_id is a valid uuid
try:
uuid.UUID(upload_file_id)
except ValueError:
raise ValueError("Invalid upload file id format")
stmt = select(UploadFile).where(
UploadFile.id == upload_file_id,
UploadFile.tenant_id == tenant_id,
Expand Down

0 comments on commit 754791e

Please sign in to comment.