Generalized freeze subroutine #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I am wrong, but I think that the vector FREEZEID is never deallocated. I suggest taking a look at that. |
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
========================================
- Coverage 46.1% 46.1% -0.1%
========================================
Files 200 200
Lines 16321 16333 +12
========================================
+ Hits 7528 7532 +4
- Misses 8793 8801 +8
Continue to review full report at Codecov.
|
|
I need them in memory during the execution of the code.
…On Tue, May 28, 2019 at 10:47 AM Nestor F. Aguirre ***@***.***> wrote:
Maybe I am wrong, but I think that the vector FREEZEID is never
deallocated. I suggest taking a look at that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#108?email_source=notifications&email_token=AD2CLNN56EFNCY4YYKTVG7LPXVO27A5CNFSM4HQFGLHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMXTZI#issuecomment-496597477>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD2CLNNY2YXEEKORTQQ46GLPXVO27ANCNFSM4HQFGLHA>
.
--
Dr. Christian F. A . Negre
LOS ALAMOS NATIONAL LABORATORY
T-1 Division, Mail Stop B221
Los Alamos, NM 87545
|
enriquemasa
approved these changes
May 28, 2019
nicolasbock
approved these changes
May 28, 2019
| DO I = 1,NFREEZE | ||
| READ(444,*)FREEZEID(I) | ||
| READ(444,*)FREEZEID(I), FREEZEIDX(I), FREEZEIDY(I), FREEZEIDZ(I) | ||
| FREEZEIDX(I) = 1 - FREEZEIDX(I) |
There was a problem hiding this comment.
Maybe add a check that FREEZEID[XYZ] is really in [0, 1]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalized freeze subroutine.