Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DBCSR_OPT option in cmake #93

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

junghans
Copy link
Member

@junghans junghans commented Nov 1, 2018

Fix #92

@junghans junghans requested a review from cnegre November 1, 2018 12:51
@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #93 into master will increase coverage by 1.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #93     +/-   ##
========================================
+ Coverage    46.1%   47.9%   +1.8%     
========================================
  Files         200     198      -2     
  Lines       16321   16108    -213     
========================================
+ Hits         7528    7730    +202     
+ Misses       8793    8378    -415
Impacted Files Coverage Δ
src/genX.F90
src/ppfit.F90
src/fspinnono_sp.F90
src/pulay_spprogress.F90
src/velverlet.F90
src/latteparser_latte_mod.F90
src/toteng.F90
src/mofit.F90
src/resetprodhd.F90
src/coulomb_ewald.F90
... and 388 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee85aa...5b0ba75. Read the comment docs.

@cnegre
Copy link
Collaborator

cnegre commented Feb 3, 2019

@junghans Do we still need this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBCSR_OPT option is broken: there's no such file dbcsr_var_mod.mod
2 participants