Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check collection type before transforming #183

Closed
wants to merge 1 commit into from
Closed

Check collection type before transforming #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Forge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use GuzzleHttp\Client as HttpClient;
use Laravel\Forge\Resources\User;
use Exception;

class Forge
{
Expand Down Expand Up @@ -76,6 +77,12 @@
*/
protected function transformCollection($collection, $class, $extraData = [])
{
if (!is_array($collection)) {
throw new Exception(
"Unexpected response format. Expected an array, got " . gettype($response)

Check failure on line 82 in src/Forge.php

View workflow job for this annotation

GitHub Actions / tests / Static Analysis 

Undefined variable: $response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$response is not a variable in this scope.

);
}

return array_map(function ($data) use ($class, $extraData) {
return new $class($data + $extraData, $this);
}, $collection);
Expand Down
Loading