Wait for the sqlite3 process to terminate #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When closing the pipe to sqlite3, the sqlite3 process is not terminated instantly which leads to race conditions with Git in `histdb-sync`. Therefore, this commit adds a block to wait for the sqlite3 process to terminate in `_histdb_stop_sqlite_pipe`.
IngoMeyer441
force-pushed
the
fix/git-race-condition
branch
from
4fe68a6
to
a791677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing the pipe to sqlite3, the sqlite3 process is not terminated
instantly which leads to race conditions with Git in
histdb-sync.Therefore, this PR adds a block to wait for the sqlite3 process to
terminate in
_histdb_stop_sqlite_pipe.