Feature/1096 protobuffer update #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudteil
force-pushed
the
feature/1096-protobuffer-update
branch
10 times, most recently
from
854a4d4 to
b32fcf9
Compare
thibaudteil
force-pushed
the
feature/1096-protobuffer-update
branch
3 times, most recently
from
61f1a58 to
f3122e5
Compare
thibaudteil
force-pushed
the
feature/1096-protobuffer-update
branch
2 times, most recently
from
eb9860e to
ee0d72f
Compare
fields of the message where relegated to another message and are removed here to be updated in the interface
remove unnecessary structs from interface and add new messages
We were using the top left corner of the pixel before leading to biases in the filter.
thibaudteil
force-pushed
the
feature/1096-protobuffer-update
branch
from
ee0d72f to
aef5943
Compare
added 3 commits
November 6, 2024 17:10
drop and add to separate branch later
thibaudteil
force-pushed
the
feature/1096-protobuffer-update
branch
from
4bbabf8 to
f17cdd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first two commits clean up some recently added modules and messages.
The third commit cleans out the cielimInterface module from all the unused messages
The other commits add the new message data and test the reading and writing of the protobufs
Verification
Unit test
Documentation
None
Future work
Many improvements to come