Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Accessibility: Add "Move to" context menu action for notebooks #11039

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Sep 13, 2024

Summary

This pull request allows changing the parent of a notebook from its context menu. Previously, it seems to have not been possible to change a folder's parent without a mouse.

This pull request modifies the existing moveToFolder command — it now supports changing the parent notebook of notebooks in addition to notes.

Note: A similar feature was originally requested on the forum.

Related to #10795.

Related WCAG guidelines

  • §2.1.1: Keyboard: "All functionality of the content is operable through a keyboard interface".
    • On my (Linux) computer, this can be done with the "context menu" key or by pressing shift-F10.

Screenshots

screenshot: Right-click menu for a notebook includes "Move to notebook"
screenshot: Dialog: Move to notebook: Visible dropdown includes options "None", "Test 2", "Test2", "Test3"

Testing plan

Manual testing (Fedora 40):

  1. Right-click on a subfolder.
  2. Click "Move to notebook".
  3. Verify that the right-clicked notebook's title is not in the list of possible notebooks.
  4. Select "None".
  5. Verify that the notebook is now toplevel.
  6. Right-click on the folder.
  7. Click "Move to notebook".
  8. Select an existing folder.
  9. Verify that the folder has been added as a subnotebook of the folder selected in step 8.

Manual regression testing (Fedora 40):

  1. Open the command palette and run :moveToFolder.
  2. Select a not-currently-selected notebook.
  3. Verify that the note has been moved to that notebook.
  4. Select multiple notes.
  5. Click "Move to notebook".
  6. Select a not-currently-selected notebook.
  7. Verify that the notes have been moved to that notebook.

@personalizedrefrigerator personalizedrefrigerator added desktop All desktop platforms accessibility Related to accessibility labels Sep 13, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Accessibility: Add "moveTo" context menu for notebooks Desktop: Accessibility: Add "Move to" context menu action for notebooks Sep 13, 2024
@laurent22 laurent22 merged commit 3c6a419 into laurent22:dev Sep 14, 2024
10 checks passed
@tomasz1986
Copy link

Thank you very much for implementing this! Although the issue is about keyboard usage, this will also make it possible to move notebooks on a touch screen (desktop) device, which is currently impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants