Desktop: Fixes #10887: Prevent disabling of textbox inputs after entering an incorrect password #11241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Joplin desktop (tested on Windows), when you use the enable encryption setting after a master password has been set, if you enter an incorrect password, then textbox inputs across the whole application are disabled as a result. This persists until minimising or restarting Joplin, or switching between different windows. This may be related to opening a standard alert dialog while a smalltalk prompt is active, as changing the validation error to use a smalltalk alert seems to fix the issue. Note that there is a slight change in behaviour in that the initial smalltalk prompt is closed when the validation error appears, but this shouldn't really be a big deal from a user perspective.
Video showing the current behaviour:
https://github.com/user-attachments/assets/6fabc55a-ae4b-47ce-b076-7f5181993130
Video showing the new behaviour:
https://github.com/user-attachments/assets/5580f810-e91d-4f55-9da7-e160ed77940e
This fixes #10887