Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new bestuurseenheid: Welzijnsvereniging Sint-Anna #600

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

aatauil
Copy link
Member

@aatauil aatauil commented Sep 19, 2024

ID

DL-6183

Description

This PR adds a new bestuurseenheid

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Maintanance

How to setup

Setup like usual making sure migration ran.

How to test

Try logging in using Sint-Anna.

@aatauil
Copy link
Member Author

aatauil commented Oct 18, 2024

@Riadabd This time followed the guide and exported the data from OP. Welzijnsverenigingen do not have personeelsaantallen so skipped that part

@aatauil
Copy link
Member Author

aatauil commented Oct 18, 2024

We might be missing the werkingsgebied triple for the bestuurseenheid but no reference fount in OP. Even though it will most likely be Antwerpen, dont want to pull triples out of thin air so left it out for now.

<http://data.vlaanderen.be/ns/mandaat#bindingStart> "2019-01-01T00:00:00Z"^^xsd:dateTime ;
<https://data.vlaanderen.be/ns/generiek#isTijdspecialisatieVan> <http://data.lblod.info/id/bestuursorganen/40bfba80-6c5d-11ef-8f29-2728b827bd59> .

<http://data.lblod.info/id/bestuursorganen/40e8ed60-6c5d-11ef-8f29-2728b827bd59> <http://data.vlaanderen.be/ns/mandaat#isTijdspecialisatieVan> <http://data.lblod.info/id/bestuursorganen/40cab700-6c5d-11ef-8f29-2728b827bd59> . # No bestuurseenheid in tijd data, only uri
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this bestuursorgaan in tijd does have triples in OP:

<http://data.lblod.info/id/bestuursorganen/40e8ed60-6c5d-11ef-8f29-2728b827bd59>
    rdf:type <http://data.vlaanderen.be/ns/besluit#Bestuursorgaan> ;
    <http://mu.semte.ch/vocabularies/core/uuid> "40e8ed60-6c5d-11ef-8f29-2728b827bd59" ;
    <http://data.vlaanderen.be/ns/mandaat#isTijdspecialisatieVan> <http://data.lblod.info/id/bestuursorganen/40cab700-6c5d-11ef-8f29-2728b827bd59> ;
    <http://data.vlaanderen.be/ns/mandaat#bindingStart> "2019-01-01T00:00:00Z"^^xsd:dateTime .

aatauil and others added 4 commits October 28, 2024 12:00
…-welzijnsvereniging-sint-anna/20240919101332-add-new-organisation-sint-anna.sparql

Co-authored-by: Riad Abdallah <[email protected]>
…-welzijnsvereniging-sint-anna/20240919101332-add-new-organisation-sint-anna.sparql

Co-authored-by: Riad Abdallah <[email protected]>
@aatauil aatauil requested a review from Riadabd October 28, 2024 11:11
@Riadabd
Copy link
Contributor

Riadabd commented Oct 29, 2024

There's still the data that needs to be added for <http://data.lblod.info/id/bestuursorganen/40e8ed60-6c5d-11ef-8f29-2728b827bd59>; it seems to have data when querying the OP database.

Copy link
Contributor

@Riadabd Riadabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment here about the final change that needs to be done before the PR is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants