-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend op consumer to all unit types #606
base: development
Are you sure you want to change the base?
Extend op consumer to all unit types #606
Conversation
505f927
to
6197ed4
Compare
They shouldn't not be in Loket, only in OP and CVP. See OP-3306 for context
Thanks, so far it's progressing, but some bugs pop up during testing. Too many bestuursorganen in toezicht.It's seems we need a more fine grained mapping rule for bestuursorganen to add them to specific concept:schemes. Too few bestuursorganen get exported by OP.E.g. for https://data.lblod.info/id/bestuurseenheden/2c80d772-5a21-4e9d-be8a-35e9bb6d66c6
|
@cecemel Thanks for testing it out ! The too many bestuursorganen part will be to be investigated. For the too few part, can you check lblod/app-organization-portal#470 ? It might help ! |
WIP because waiting for confirmation on which classifications to keep on DL-6219, and the query seems to big to come through (at least for the first run). Might be solved if we exclude more classifications.
1. there was a missing concept, not present in the loket-cli, but probs added later. 2. moved filter to subquery, since that get's executed first. So less heavy query. 3. added default obsValue
Cleanup job: personeel data
Context
DL-6217 & DL-6218
Details
In this PR, we:
How to test
@cecemel said it all in his analysis on DL-5713:
I have tested for PEVA Gemeente, it flow to Loket, the
update-bestuurseenheid-mock-login
service does create the mock-login user and we can access the app.What's next
DL-6219: we should now create
Personeelsdatabank
data for those imported admin units. The mock-login service still does its job as long as we don't consume other organizations that are notbesluit:Bestuurseenheid
.