[DL-6006] Add the DecisionArticles validator
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we use the same validations as the frontend. We simply copy paste the implementation for now since it is unlikely to change much once it is stable and it allows us to do extra things in the backend version if needed. Related code: lblod/frontend-loket#391
Windvis
commented
Jun 12, 2024
| formGraph, | ||
| ); | ||
|
|
||
| return typeof literal !== 'undefined' && literal !== null && Literal.toJS(literal); |
There was a problem hiding this comment.
It seems that the store in this service is not a "ForkingStore" instance, but a regular rdflib one. The rdflib version seems to return null instead of undefined if there is no data in the graph.
We probably should:
- also return
nullin the forking store version - also use a forking store in this service, instead of the rdflib version to make the behaviour between frontend and backend (or other services) more consistent
But I think that's out of scope for this feature since the workaround is simple enough.
Windvis
commented
Jun 12, 2024
There was a problem hiding this comment.
I also removed some imports that weren't being used anymore.
Windvis
changed the title
DecisionArticles validatorDecisionArticles validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we use the same validations as the frontend. We simply copy paste the implementation for now since it is unlikely to change much once it is stable and it allows us to do extra things in the backend version if needed.
Related PRs:
DecisionArticlesfield and validator frontend-loket#391Builds on #11 so that needs to be merged first.