Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lbcdblocknotify: support multiple stratum server #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterpan0708
Copy link

support notify to multiple stratum servers

@lbry-bot lbry-bot assigned roylee17 and unassigned roylee17 Oct 18, 2022
@lbry-bot lbry-bot assigned roylee17 and unassigned roylee17 Oct 18, 2022
@roylee17
Copy link
Collaborator

roylee17 commented Oct 18, 2022

LGTM.

Ideally, we'd like to fan out with multiple stratum connections(or clients), not multiple bridges.
But the current codebase is not friendly to extend it that way.

So I think we can have this working feature merged now and update it in future iterations.
A minor preference is to update the stratum flag to a list style as shown in those inline comments.

This has been requested by multiple pools. So, thanks a lot for the contribution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants