Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax witness size checking #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Relax witness size checking #103

wants to merge 2 commits into from

Commits on May 1, 2023

  1. wire: remove erroneous witness size check in wire parsing 

    In this commit, we fix a bug that would cause nodes to be unable to
parse a given block from the wire. The block would be properly accepted
if fed in via other mechanisms.

The issue here is that the old checks for the maximum witness size,
circa segwit v0 where placed in the wire package _as well_ as the tx
engine. This check should only be in the engine, since it's properly
gated by other related scrip validation flags.

The fix itself is simple: limit witnesses only based on the maximum
block size in bytes, or ~4MB.
    @Roasbeef @roylee17
    Roasbeef authored and roylee17 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    df89776 View commit details
    Browse the repository at this point in the history

  2. wire: increase max witness items per input

    @ellemouton @roylee17
    ellemouton authored and roylee17 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c96645c View commit details
    Browse the repository at this point in the history