Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import Mathlib.Tactic
pulls in a huge amount of mathlib (there are many domain-specific tactics).Before this PR:
After this PR you can build the entire project without even downloading mathlib cache very quickly:
One possible downside was that I tried this approach with NNG3 and I remember someone complaining that they wanted to use fancy tactics to solve levels but the fancy tactics weren't imported. However if someone has a genuine need for a tactic which is now no longer available then we could just make a new PR adding the import of that particular tactic, which is unlikely to be e.g. a bespoke Witt vector tactic which imports 1000 algebra files from mathlib.
I have no feeling about whether this makes any practical difference to e.g. space requirements for the game, but if it does then it looks like a pretty simple fix.